[ https://issues.apache.org/jira/browse/TEZ-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596751#comment-16596751 ]
Gopal V commented on TEZ-3984: ------------------------------ The patch looks good - minor NIT, the OrderedPartitionedKVOutput event lists need to be prefixed. The sorter events need to be inserted at 0, not appended (for event order related issues - which doesn't exist today, because it is likely to be no events in generateEvents but is neater to see them in order in the AM). > Shuffle: Out of Band DME event sending causes errors > ---------------------------------------------------- > > Key: TEZ-3984 > URL: https://issues.apache.org/jira/browse/TEZ-3984 > Project: Apache Tez > Issue Type: Bug > Affects Versions: 0.8.4, 0.9.1, 0.10.0 > Reporter: Gopal V > Assignee: Jaume M > Priority: Critical > Labels: correctness > Attachments: TEZ-3984.1.patch > > > In case of a task Input throwing an exception, the outputs are also closed in > the LogicalIOProcessorRuntimeTask.cleanup(). > Cleanup ignore all the events returned by output close, however if any output > tries to send an event out of band by directly calling > outputContext.sendEvents(events), then those events can reach the AM before > the task failure is reported. > This can cause correctness issues with shuffle since zero sized events can be > sent out due to an input failure and downstream tasks may never reattempt a > fetch from the valid attempt. -- This message was sent by Atlassian JIRA (v7.6.3#76005)