[ https://issues.apache.org/jira/browse/TEZ-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653071#comment-16653071 ]
Harish Jaiprakash commented on TEZ-3979: ---------------------------------------- +1, change looks fine. Just one question, should you merge mapreduce.job.redacted-properties in MRTask incase its set. > Redact configuration when it's being logged, sent to the timeline server or > displayed in some way > ------------------------------------------------------------------------------------------------- > > Key: TEZ-3979 > URL: https://issues.apache.org/jira/browse/TEZ-3979 > Project: Apache Tez > Issue Type: Bug > Components: UI > Affects Versions: 0.9.1 > Reporter: Jaume M > Assignee: Jaume M > Priority: Major > Attachments: TEZ-3979.1.patch, TEZ-3979.2.patch, TEZ-3979.3.patch > > > The configuration is being logged in some places like > [here|https://github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e287c85ad50/tez-dag/src/main/java/org/apache/tez/dag/history/utils/DAGUtils.java#L508] > and > [here|https://github.com/apache/tez/blob/90c8195de0ddee9da3d4cd07519c8e287c85ad50/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/processor/MRTask.java#L177] > . We should do something like [what it's done in the hadoop code > base|https://github.com/apache/hadoop/blob/d951af22b42a22c09cfeecd3c866d5f1cd412120/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java#L558] > and redact the properties held in {{mapreduce.job.redacted-properties.}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)