[ 
https://issues.apache.org/jira/browse/TEZ-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766762#comment-16766762
 ] 

TezQA commented on TEZ-3985:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  8m 
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m 
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
18s{color} | {color:red} tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 
42s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
19s{color} | {color:red} tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 
25s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 19s{color} 
| {color:red} tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 25s{color} 
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 23s{color} | {color:orange} tez-runtime-internals: The patch generated 1 new 
+ 326 unchanged - 2 fixed = 327 total (was 328) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 41s{color} | {color:orange} root: The patch generated 1 new + 334 unchanged 
- 2 fixed = 335 total (was 336) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color} 
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
19s{color} | {color:red} tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 
21s{color} | {color:red} tez-runtime-internals generated 2 new + 0 unchanged - 
0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m 
22s{color} | {color:red} root generated 2 new + 31 unchanged - 0 fixed = 33 
total (was 31) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
55s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m 19s{color} 
| {color:red} tez-runtime-internals in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m  8s{color} 
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}1488m 
28s{color} | {color:red} The patch generated 1359 ASF License warnings. {color} 
|
| {color:black}{color} | {color:black} {color} | {color:black}1525m  7s{color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/tez:d4a62de |
| JIRA Issue | TEZ-3985 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12958096/TEZ-3985.4.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  xml  compile  
findbugs  checkstyle  |
| uname | Linux 8b5c1d05c5ee 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 3162aab |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.0.1 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-mvninstall-tez-runtime-internals.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-mvninstall-root.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-compile-tez-runtime-internals.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-compile-root.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-compile-tez-runtime-internals.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-compile-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/diff-checkstyle-tez-runtime-internals.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/diff-checkstyle-root.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-findbugs-tez-runtime-internals.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/diff-javadoc-javadoc-tez-runtime-internals.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/diff-javadoc-javadoc-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-unit-tez-runtime-internals.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-TEZ-Build/86/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 394 (vs. ulimit of 10000) |
| modules | C: tez-api tez-runtime-internals . U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/86/console 
|
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Correctness: Throw a clear exception for DMEs sent during cleanup
> -----------------------------------------------------------------
>
>                 Key: TEZ-3985
>                 URL: https://issues.apache.org/jira/browse/TEZ-3985
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3985.1.patch, TEZ-3985.2.patch, TEZ-3985.3.patch, 
> TEZ-3985.3.patch, TEZ-3985.4.patch
>
>
> If a DME is sent during cleanup, that implies that the .close() of the 
> LogicalIOProcessorRuntimeTask did not succeed and therefore these events are 
> an error condition.
> These events should not be sent and more importantly should be received by 
> the AM.
> Throw a clear exception, in case of this & allow the developers to locate the 
> extraneous event from the backtrace.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to