[ https://issues.apache.org/jira/browse/TEZ-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988208#comment-16988208 ]
TezQA commented on TEZ-4103: ---------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} tez-api: The patch generated 0 new + 8 unchanged - 6 fixed = 8 total (was 14) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} The patch passed checkstyle in tez-runtime-internals {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} The patch passed checkstyle in tez-mapreduce {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} tez-dag: The patch generated 0 new + 397 unchanged - 1 fixed = 397 total (was 398) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 50s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 48s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 13s{color} | {color:green} tez-mapreduce in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 29s{color} | {color:red} tez-dag in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 3s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | tez.dag.app.TestSpeculation | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 Image:yetus/tez:d4a62deee | | JIRA Issue | TEZ-4103 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12987502/TEZ-4103.006.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux d3b3fe74d031 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / 1af0897 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_222 | | findbugs | v3.0.1 | | unit | https://builds.apache.org/job/PreCommit-TEZ-Build/211/artifact/out/patch-unit-tez-dag.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/211/testReport/ | | Max. process+thread count | 267 (vs. ulimit of 5500) | | modules | C: tez-api tez-runtime-internals tez-mapreduce tez-dag U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/211/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Progress in DAG, Vertex, and tasks is incorrect > ----------------------------------------------- > > Key: TEZ-4103 > URL: https://issues.apache.org/jira/browse/TEZ-4103 > Project: Apache Tez > Issue Type: Bug > Reporter: Ahmed Hussein > Assignee: Ahmed Hussein > Priority: Major > Attachments: TEZ-4103.001.patch, TEZ-4103.002.patch, > TEZ-4103.003.patch, TEZ-4103.004.patch, TEZ-4103.005.patch, TEZ-4103.006.patch > > > Looking at the progress code, there some few issues that could lead to some > problems calculating the progress. > There are some cases when the progress never reach 1.0. > This is a list of issues that need to be fixed in the progress code: > * After TEZ-3982, since values are skipped in the In some cases, the > progress of DAG or a vertex may never reach 1.0f. this is in both > "{{DAGImpl.java}}" and "{{ProgressHelper.java}}" > * {{ProgressHelper}} schedules a service to update the progress, dubbed > `{{ProgressHelper.monitorProgress}}`. According to Java Documentation: > {quote}If any execution of the task encounters an exception, > subsequent executions are suppressed. > Otherwise, the task will only terminate via cancellation > or termination of the executor. > {quote} > In other words, if the service dies, there is no way to catch that in the > code and the progress will never be updated. > * The `{{SimpleProcessor.inputMap}}` is not thread-safe. They are > initialized as `{{LinkedHashMap}}` and there is no synchronization on the > field objects in the map. This could be problematic in concurrent context. > * `{{VertexImpl.getProgress()}}` does not check the range of the progress > calculated in `{{VertexImpl.computeProgress()}}` > -- This message was sent by Atlassian Jira (v8.3.4#803005)