[ https://issues.apache.org/jira/browse/TEZ-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999245#comment-16999245 ]
TezQA commented on TEZ-4109: ---------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m 37s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 15s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 14s{color} | {color:orange} tez-api: The patch generated 1 new + 74 unchanged - 0 fixed = 75 total (was 74) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 38s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 49s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 47s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 33s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 38s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/PreCommit-TEZ-Build/232/artifact/out/Dockerfile | | JIRA Issue | TEZ-4109 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12989113/TEZ-4109.02.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux e610c7a04e24 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / a6219ed | | Default Java | 1.8.0_222 | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/232/artifact/out/diff-checkstyle-tez-api.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/232/testReport/ | | Max. process+thread count | 953 (vs. ulimit of 5500) | | modules | C: tez-api tez-runtime-internals tez-dag tez-ext-service-tests U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/232/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. > Improve TezCommonUtils.getCredentialsInfo and use it from more contexts > ----------------------------------------------------------------------- > > Key: TEZ-4109 > URL: https://issues.apache.org/jira/browse/TEZ-4109 > Project: Apache Tez > Issue Type: Improvement > Reporter: László Bodor > Assignee: László Bodor > Priority: Major > Attachments: TEZ-4109.01.patch, TEZ-4109.02.patch > > > While debugging token related issues, I found the current implementation of > TezCommonUtils.getCredentialsInfo doesn't provide enough info about tokens. > 1. as it's used on DEBUG level (called from logCredentials, which has a > debugenabled check), it should give more verbose output > currently it's > {code} > token.getService()).append("(").append(token.getKind()).append(")") > {code} > but in case of delegation token issue, we would need to see token's full > string representation, like this below: > {code} > Kind: HDFS_DELEGATION_TOKEN, Service: 10.14.67.148:8020, Ident: (token for > hive: HDFS_DELEGATION_TOKEN > owner=hive/dev-lbodor-hiveontez-sec-3.domain.com@REALM, renewer=yarn, > realUser=, issueDate=1573566780144, maxDate=1574171580144, > sequenceNumber=7611, masterKeyId=3) > {code} > 2. It should be called from more code paths (e.g. from within tasks), so it's > going to let us follow tokens for every level of execution (AM, Container, > Task) -- This message was sent by Atlassian Jira (v8.3.4#803005)