[ 
https://issues.apache.org/jira/browse/TEZ-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112701#comment-17112701
 ] 

TezQA commented on TEZ-4186:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m 
28s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  5m  
8s{color} | {color:blue} Used deprecated FindBugs config; considering switching 
to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  5m  
3s{color} | {color:red} root in master has 2 extant findbugs warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 13s{color} | {color:orange} tez-api: The patch generated 1 new + 7 unchanged 
- 0 fixed = 8 total (was 7) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 32s{color} | {color:orange} root: The patch generated 1 new + 7 unchanged - 
0 fixed = 8 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
46s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 62m 
12s{color} | {color:green} root in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
27s{color} | {color:red} The patch generated 13 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}104m 48s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.9 Server=19.03.9 base: 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4186 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13003592/TEZ-4186.1.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs 
findbugs checkstyle |
| uname | Linux 7ae72172c5af 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 07c807b |
| Default Java | 1.8.0_252 |
| findbugs | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/artifact/out/branch-findbugs-root-warnings.html
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/artifact/out/diff-checkstyle-tez-api.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/artifact/out/diff-checkstyle-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/artifact/out/patch-asflicense-problems.txt
 |
| Max. process+thread count | 1640 (vs. ulimit of 5500) |
| modules | C: tez-api . U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-TEZ-Build/442/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> Limits: Fix init order regression from TEZ-4155
> -----------------------------------------------
>
>                 Key: TEZ-4186
>                 URL: https://issues.apache.org/jira/browse/TEZ-4186
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Gopal Vijayaraghavan
>            Assignee: Gopal Vijayaraghavan
>            Priority: Major
>         Attachments: TEZ-4186.1.patch
>
>
> After TEZ-4155, the AM is not able to configure Limits parameters correctly, 
> due to the following interaction.
> {code}
>   static {
>     init(new TezConfiguration());
>   }
> {code}
> prevents setConfiguration from doing anything
> {code}
>   public synchronized static void setConfiguration(Configuration conf) {
>     if (Limits.conf == null && conf != null) {
>       init(conf);
>     }
>   }
> {code}
> since the Limits.conf is never null.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to