[ https://issues.apache.org/jira/browse/TEZ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159401#comment-17159401 ]
TezQA commented on TEZ-4133: ---------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 34s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m 50s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 47s{color} | {color:red} tez-runtime-library in master has 1 extant findbugs warnings. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 16s{color} | {color:orange} tez-runtime-library: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 47s{color} | {color:green} tez-runtime-library in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 9s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 26s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-TEZ-Build/483/artifact/out/Dockerfile | | JIRA Issue | TEZ-4133 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13005618/TEZ-4133-1.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux aaae92b4d1cd 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / 5944982cd | | Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 | | findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/483/artifact/out/branch-findbugs-tez-runtime-library-warnings.html | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/483/artifact/out/diff-checkstyle-tez-runtime-library.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/483/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-TEZ-Build/483/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 127 (vs. ulimit of 5500) | | modules | C: tez-runtime-library U: tez-runtime-library | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/483/console | | versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > key class implments writableComparable and configurable use default > configuration > --------------------------------------------------------------------------------- > > Key: TEZ-4133 > URL: https://issues.apache.org/jira/browse/TEZ-4133 > Project: Apache Tez > Issue Type: Bug > Reporter: wang qiang > Priority: Major > Attachments: TEZ-4133-1.patch > > > key class implments writableComparable and configurable ,setConf be invoked > with a default configuration,it should like > mapreduce(org.apache.hadoop.mapred.JobConf#getOutputKeyComparator) > {code:java} > //org.apache.tez.runtime.library.common.ConfigUtils#getIntermediateOutputKeyComparator > public static <K> RawComparator<K> > getIntermediateOutputKeyComparator(Configuration conf) { > Class<? extends RawComparator> theClass = conf.getClass( > TezRuntimeConfiguration.TEZ_RUNTIME_KEY_COMPARATOR_CLASS, null, > RawComparator.class); > if (theClass != null) > return ReflectionUtils.newInstance(theClass, conf); > // aybe change to > // return > WritableComparator.get(getIntermediateOutputKeyClass(conf).asSubclass( > //WritableComparable.class),conf); > return > WritableComparator.get(getIntermediateOutputKeyClass(conf).asSubclass( > WritableComparable.class)); > } > public static <K> RawComparator<K> > getIntermediateInputKeyComparator(Configuration conf) { > Class<? extends RawComparator> theClass = conf.getClass( > TezRuntimeConfiguration.TEZ_RUNTIME_KEY_COMPARATOR_CLASS, null, > RawComparator.class); > if (theClass != null) > return ReflectionUtils.newInstance(theClass, conf); > // maybe change to > // return > WritableComparator.get(getIntermediateInputKeyClass(conf).asSubclass( > //WritableComparable.class),conf); > return WritableComparator.get(getIntermediateInputKeyClass(conf).asSubclass( > WritableComparable.class)); > } > {code} > > > > > > > > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)