[ https://issues.apache.org/jira/browse/TEZ-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172504#comment-17172504 ]
TezQA commented on TEZ-4213: ---------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 1s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m 9s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 4s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 20s{color} | {color:red} tez-dag generated 3 new + 5 unchanged - 3 fixed = 8 total (was 8) {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 17s{color} | {color:orange} tez-dag: The patch generated 5 new + 73 unchanged - 2 fixed = 78 total (was 75) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 6s{color} | {color:red} tez-dag generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 9s{color} | {color:green} tez-dag in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 8s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:tez-dag | | | Inconsistent synchronization of org.apache.tez.dag.app.DAGAppMaster.rawExecutor; locked 66% of time Unsynchronized access at DAGAppMaster.java:66% of time Unsynchronized access at DAGAppMaster.java:[line 1533] | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-TEZ-Build/516/artifact/out/Dockerfile | | JIRA Issue | TEZ-4213 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13009221/TEZ-4213.03.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux 676fe6cb6343 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / 3ce961bc7 | | Default Java | Private Build-1.8.0_252-8u252-b09-1~18.04-b09 | | javac | https://builds.apache.org/job/PreCommit-TEZ-Build/516/artifact/out/diff-compile-javac-tez-dag.txt | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/516/artifact/out/diff-checkstyle-tez-dag.txt | | findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/516/artifact/out/new-findbugs-tez-dag.html | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/516/testReport/ | | Max. process+thread count | 260 (vs. ulimit of 5500) | | modules | C: tez-api tez-dag U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/516/console | | versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Bound appContext executor capacity using a configurable property > ---------------------------------------------------------------- > > Key: TEZ-4213 > URL: https://issues.apache.org/jira/browse/TEZ-4213 > Project: Apache Tez > Issue Type: Bug > Reporter: Panagiotis Garefalakis > Assignee: Panagiotis Garefalakis > Priority: Major > Attachments: TEZ-4213.01.patch, TEZ-4213.02.patch, TEZ-4213.03.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > After TEZ-4170 was merged, appContext executor pool is also used by the > RootInputInitializerManager to speed up SplitGeneration. > However, this executor pool currently has not capacity limit > https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L624 > The problem the occurs when generating splits for larger inputs (thousands or > more) is that it can could result to > {color:red}java.lang.OutOfMemoryError{color} > that is also reproducible with a test case. > https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/dag/RootInputInitializerManager.java#L130 > To avoid such errors, I propose to limit the capacity of this pool to a > configurable value that can be for example the number of physical cores by > default. -- This message was sent by Atlassian Jira (v8.3.4#803005)