[
https://issues.apache.org/jira/browse/TEZ-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213256#comment-17213256
]
Hadoop QA commented on TEZ-4157:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
56s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
52s{color} | {color:red} root in master has 2 extant findbugs warnings. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 22s{color} | {color:orange} tez-ext-service-tests: The patch generated 4 new
+ 31 unchanged - 7 fixed = 35 total (was 38) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 23s{color} | {color:orange} tez-plugins/tez-aux-services: The patch
generated 1 new + 68 unchanged - 8 fixed = 69 total (was 76) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 41s{color} | {color:orange} root: The patch generated 5 new + 99 unchanged -
15 fixed = 104 total (was 114) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
3s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
46s{color} | {color:green} tez-aux-services in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 47m 1s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}101m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.test.TestRecovery |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/Dockerfile
|
| JIRA Issue | TEZ-4157 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13013508/TEZ-4157.04.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs
findbugs checkstyle |
| uname | Linux d6d7683767d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 16a005090 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| findbugs |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/branch-findbugs-root-warnings.html
|
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/diff-checkstyle-tez-ext-service-tests.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/artifact/out/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/testReport/ |
| Max. process+thread count | 1405 (vs. ulimit of 5500) |
| modules | C: tez-ext-service-tests tez-plugins/tez-aux-services . U: . |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/38/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> ShuffleHandler: upgrade to netty4
> ---------------------------------
>
> Key: TEZ-4157
> URL: https://issues.apache.org/jira/browse/TEZ-4157
> Project: Apache Tez
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4157.01.patch, TEZ-4157.02.patch, TEZ-4157.03.patch,
> TEZ-4157.04.patch
>
>
> -In the dependency tree, there are 2 occurrences of compile scope direct
> netty dependencies, however, they're not used at all. I compiled locally
> successfully without them. E.g. when investigating blackduck alerts
> (complaining about netty deps for current 3.10.5.Final), it would be cleaner
> to start from a dependency tree where Tez doesn't depend on netty directly in
> order to eliminate its responsibility (and move the focus to underlying
> hadoop for instance).-
> Tez depends on netty3 almost only in ShuffleHandler and some related classes.
> We can eliminate netty3 by upgrading it, but this effort might involve some
> testing due to fundamental [changes from
> netty3->netty4|https://netty.io/wiki/new-and-noteworthy-in-4.0.html] + we
> don't have a reference yet, as [hadoop's
> ShuffleHandler|https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java]
> is still on netty3.
> As per the netty documentation, we can also expect some performance
> improvement (e.g. Pooled buffers).
> Background:
> netty4 migration guideline:
> https://netty.io/wiki/new-and-noteworthy-in-4.0.html
> articles of possible performance improvement:
> https://blog.twitter.com/engineering/en_us/a/2013/netty-4-at-twitter-reduced-gc-overhead.html
> https://developer.squareup.com/blog/upgrading-a-reverse-proxy-from-netty-3-to-4/
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
