[
https://issues.apache.org/jira/browse/TEZ-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238937#comment-17238937
]
Hadoop QA commented on TEZ-4253:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
49s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} tez-dag generated 2 new + 6 unchanged - 2 fixed = 8 total (was 8)
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} tez-dag: The patch generated 0 new + 447 unchanged -
18 fixed = 447 total (was 465) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} tez-dag generated 0 new + 0 unchanged - 1 fixed = 0
total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
16s{color} | {color:green} tez-dag in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/62/artifact/out/Dockerfile
|
| JIRA Issue | TEZ-4253 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13016047/TEZ-4253.2.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
checkstyle compile |
| uname | Linux 7cda062e0cac 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 938d6a105 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| javac |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/62/artifact/out/diff-compile-javac-tez-dag.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/62/testReport/ |
| Max. process+thread count | 234 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/62/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Revert TEZ-4170
> ---------------
>
> Key: TEZ-4253
> URL: https://issues.apache.org/jira/browse/TEZ-4253
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Mustafa İman
> Assignee: Mustafa İman
> Priority: Major
> Attachments: TEZ-4253.2.patch, TEZ-4253.2.patch, TEZ-4253.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are two performance improvements in
> https://issues.apache.org/jira/browse/TEZ-4170
> # Move construction of InputInitializers to background thread
> # Remove RootInputInitializerManager's thread pool and move all threads
> using this executor to DagAppMaster's thread pool.
> Item 1: This is an incorrect optimization which may cause data races in
> VertexImpl regarding handling of events. This was mitigated in
> https://issues.apache.org/jira/browse/TEZ-4204 however the solution basically
> reverts back the initial optimization only with a more complicated approach.
> Apart from these, it unnecessarily complicates Tez application master. The
> scenario where this is useful is when a custom InputInitializer constructor
> contains a lot of heavyweight operations. However, the solution to this
> problem belongs to client application. Client application can easily move
> heavyweight operations to InputInitializer#initialize method.
> Item 2: The benefit of this is doubtful. Supposedly a root input initializer
> is offloaded to a cached thread in appcontext instead of creating a new one
> in RootInputInitializerManager. The number of threads of this pool is
> limited. When many root input initializer depends on InputInitializerEvents
> all threads may get blocked. In that case the rest of the vertices (which are
> supposed to send the InputInitializerEvents) cannot run. So we run into a
> deadlock.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
