[ https://issues.apache.org/jira/browse/TEZ-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244965#comment-17244965 ]
Hadoop QA commented on TEZ-4250: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m 53s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 34s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m 9s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 17s{color} | {color:orange} tez-dag: The patch generated 1 new + 68 unchanged - 1 fixed = 69 total (was 69) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 9s{color} | {color:red} tez-dag in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 1s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | tez.dag.app.dag.impl.TestVertexImpl | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/68/artifact/out/Dockerfile | | JIRA Issue | TEZ-4250 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13016590/TEZ-4250.01.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux ccb57767d478 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / 33f989ca8 | | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 | | checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/68/artifact/out/diff-checkstyle-tez-dag.txt | | unit | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/68/artifact/out/patch-unit-tez-dag.txt | | Test Results | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/68/testReport/ | | Max. process+thread count | 188 (vs. ulimit of 5500) | | modules | C: tez-dag U: tez-dag | | Console output | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/68/console | | versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Optimise TaskImpl::getCounters > ------------------------------- > > Key: TEZ-4250 > URL: https://issues.apache.org/jira/browse/TEZ-4250 > Project: Apache Tez > Issue Type: Improvement > Reporter: Rajesh Balamohan > Priority: Major > Attachments: TEZ-4250.01.patch, TEZ-4250.patch, > image-2020-11-17-14-05-09-294.png > > > It would be good to have the temp counters only when speculation is enabled. > Current impl causes overhead for short running queries/tasks. > > !image-2020-11-17-14-05-09-294.png|width=794,height=355! -- This message was sent by Atlassian Jira (v8.3.4#803005)