LA-Toth commented on a change in pull request #187:
URL: https://github.com/apache/tez/pull/187#discussion_r809867022
##########
File path: tez-tools/pom.xml
##########
@@ -50,6 +50,25 @@
<module>tez-tfile-parser</module>
</modules>
</profile>
+ <profile>
+ <id>jdk1.8</id>
+ <activation>
+ <jdk>1.8</jdk>
+ </activation>
+ <modules>
+ <module>tez-javadoc-tools-base-jdk8</module>
+ </modules>
+ </profile>
+ <profile>
+ <id>jdk9plus</id>
+ <activation>
+ <!-- JDK9 starts strong encapsulation of Java internals, JDK17
removes/hides those -->
+ <jdk>[9,9999)</jdk>
Review comment:
This is a range of versions, based on
https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html I wanted to
write for JDK version 9 and up:
` <jdk>[9,)</jdk>`
It also could be 17 and up as only 17 enforces the new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
