abstractdog commented on code in PR #236:
URL: https://github.com/apache/tez/pull/236#discussion_r950120768


##########
tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerManager.java:
##########
@@ -839,6 +855,60 @@ protected void instantiateSchedulers(String host, int 
port, String trackingUrl,
     }
   }
 
+  @Test(timeout = 10000)
+  public void testHandleException() throws Exception {
+    Configuration tezConf = new Configuration(new YarnConfiguration());
+    UserPayload defaultPayload = TezUtils.createUserPayloadFromConf(tezConf);
+
+    // Parse plugins
+    List<NamedEntityDescriptor> tsDescriptors;
+    BiMap<String, Integer> tsMap;
+    tsDescriptors = Lists.newLinkedList();

Review Comment:
   thanks, also if you can fix any of these:
   
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-236/1/artifact/out/diff-checkstyle-tez-dag.txt
   ```
   
./tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerHelpers.java:164:
    public TaskSchedulerManagerForTest(AppContext appContext,:5: Redundant 
'public' modifier. [RedundantModifier]
   
./tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerManager.java:908:
    waitFor(() -> { return eventHandler.getEventSize() > 0;}, 1000, 5000);:19: 
'{' at column 19 should have line break after. [LeftCurly]
   
./tez-dag/src/test/java/org/apache/tez/dag/app/rm/TestTaskSchedulerManager.java:908:
    waitFor(() -> { return eventHandler.getEventSize() > 0;}, 1000, 5000);:59: 
';' is not followed by whitespace. [WhitespaceAfter]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to