[ https://issues.apache.org/jira/browse/TEZ-4039 ]
László Bodor deleted comment on TEZ-4039: ----------------------------------- was (Author: tezqa): | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 32s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 19s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m 38s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 51s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 8s{color} | {color:orange} tez-common: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 12s{color} | {color:orange} tez-runtime-internals: The patch generated 4 new + 94 unchanged - 1 fixed = 98 total (was 95) {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 19s{color} | {color:orange} tez-dag: The patch generated 1 new + 53 unchanged - 0 fixed = 54 total (was 53) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 34s{color} | {color:red} tez-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 44s{color} | {color:green} tez-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s{color} | {color:green} tez-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 40s{color} | {color:green} tez-runtime-internals in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 23s{color} | {color:red} tez-dag in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 50s{color} | {color:green} tez-ext-service-tests in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 43s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 37m 24s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:tez-common | | | Invocation of toString on org.apache.hadoop.conf.Configuration.getStrings(String, String[]) in org.apache.tez.util.LoggingUtils.initLoggingContext(Configuration, String, String) At LoggingUtils.java:String[]) in org.apache.tez.util.LoggingUtils.initLoggingContext(Configuration, String, String) At LoggingUtils.java:[line 43] | | Failed junit tests | tez.dag.app.TestSpeculation | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/Dockerfile | | JIRA Issue | TEZ-4039 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12994323/TEZ-4039.03.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile | | uname | Linux 98e2ac55b8a7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/tez.sh | | git revision | master / 9be1b1c | | Default Java | 1.8.0_242 | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/diff-checkstyle-tez-common.txt | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/diff-checkstyle-tez-runtime-internals.txt | | checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/diff-checkstyle-tez-dag.txt | | findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/new-findbugs-tez-common.html | | unit | https://builds.apache.org/job/PreCommit-TEZ-Build/303/artifact/out/patch-unit-tez-dag.txt | | Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/303/testReport/ | | Max. process+thread count | 956 (vs. ulimit of 5500) | | modules | C: tez-api tez-common tez-runtime-internals tez-dag tez-ext-service-tests U: . | | Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/303/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. > Tez should inject dag id, query id into MDC > ------------------------------------------- > > Key: TEZ-4039 > URL: https://issues.apache.org/jira/browse/TEZ-4039 > Project: Apache Tez > Issue Type: Bug > Reporter: Prasanth Jayachandran > Assignee: László Bodor > Priority: Major > Attachments: TEZ-4039.01.patch, TEZ-4039.02.patch, TEZ-4039.03.patch, > TEZ-4039.04.patch, TEZ-4039.05.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Tez currently uses CallableWithNdc to store thread specific context. It > should also inject the context into MDC so that pattern layout can dump the > contexts from MDC (with NDC it is not possible to read the context in pattern > lyaout). > Hive for example, sets queryId in the MDC and pattern layout prints the > queryId > > {code:java} > %d{ISO8601} %-5p [%t (%X{queryId})] %c{2}: %m%n > {code} > Llap sets dagId, fragmentId and queryId into MDC which is used for queryId > based routing of logging. > Similarly, Tez AM should set dagId and queryId (if available) into MDC. -- This message was sent by Atlassian Jira (v8.20.10#820010)