[
https://issues.apache.org/jira/browse/TEZ-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735627#comment-17735627
]
Ayush Saxena commented on TEZ-4250:
-----------------------------------
Fixed the test, Have a PR, I had a green build - checkstyle, I have fixed that,
didn't go with {{incrAllCounters}}, but rather created a {{setCounters}}
method, increment in general was incrementing the existing counter, presently
they were none, so it was working, but didn't look from correctness point of
view to me.
Please Review!!!
> Optimise TaskImpl::getCounters
> -------------------------------
>
> Key: TEZ-4250
> URL: https://issues.apache.org/jira/browse/TEZ-4250
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Fix For: 0.10.3
>
> Attachments: TEZ-4250.01.patch, TEZ-4250.patch,
> image-2020-11-17-14-05-09-294.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It would be good to have the temp counters only when speculation is enabled.
> Current impl causes overhead for short running queries/tasks.
>
> !image-2020-11-17-14-05-09-294.png|width=794,height=355!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
