okumin commented on code in PR #306:
URL: https://github.com/apache/tez/pull/306#discussion_r1285542632
##########
tez-runtime-library/src/main/java/org/apache/tez/dag/library/vertexmanager/FairShuffleVertexManager.java:
##########
@@ -192,18 +188,6 @@ public FairShuffleVertexManager(VertexManagerPluginContext
context) {
super(context);
}
- @Override
- protected void onVertexStartedCheck() {
- super.onVertexStartedCheck();
- if (bipartiteSources > 1 &&
- (mgrConfig.getFairRoutingType().fairParallelismEnabled())) {
- // TODO TEZ-3500
- throw new TezUncheckedException(
- "Having more than one destination task process same partition(s) " +
- "only works with one bipartite source.");
- }
Review Comment:
I expect this assertion is not must because Tez users currently use
FairShuffleVertexManager in specific cases on purpose.
I guess we need to add a new DataMovementType or new
FairShuffleVertexManager for JOIN, but we don't immediately need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
