abstractdog commented on code in PR #309:
URL: https://github.com/apache/tez/pull/309#discussion_r1342735956
##########
tez-dag/src/main/java/org/apache/tez/dag/app/RecoveryParser.java:
##########
@@ -659,11 +661,11 @@ public DAGRecoveryData parseRecoveryData() throws
IOException {
List<Path> summaryFiles = getSummaryFiles();
LOG.debug("SummaryFile size:" + summaryFiles.size());
for (Path summaryFile : summaryFiles) {
- FileStatus summaryFileStatus = recoveryFS.getFileStatus(summaryFile);
- LOG.info("Parsing summary file"
- + ", path=" + summaryFile.toString()
- + ", len=" + summaryFileStatus.getLen()
- + ", lastModTime=" + summaryFileStatus.getModificationTime());
+ if (LOG.isDebugEnabled()) {
Review Comment:
I believe we might want to keep this on INFO level
recovery is not a heavily used code path under normal circumstances, and AN
extra filesystem call due to getFileStatus is fine, especially if we're deep
inside in debugging a non-reproducible recovery issue, where we usually want to
see summary file info every time: which we would lose otherwise on DEBUG level,
as by default we're on INFO level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
