[
https://issues.apache.org/jira/browse/TEZ-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated TEZ-4519:
------------------------------
Description:
having classes like TezTaskRunner2 is clearly a code smell especially if the
original class is not present in the code anymore
it would be beneficial to change or remove the
[comment|https://github.com/apache/tez/blob/5bba1fffdd290ae3242615c23ab3b75c24f15e88/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner2.java#L59-L61]
accordingly:
{code}
// Behaviour changes as compared to TezTaskRunner
// - Exception not thrown. Instead returned in the result.
// - The actual exception is part of the result, instead of requiring a
getCause().
{code}
look at:
{code}
find . -name "*2*.java"
{code}
was:
like: TezTaskRunner2 and anything which is related
important to change the comment accordingly:
{code}
// Behaviour changes as compared to TezTaskRunner
// - Exception not thrown. Instead returned in the result.
// - The actual exception is part of the result, instead of requiring a
getCause().
{code}
> Consider renaming classes like AnyThing2 if the original is not present in
> the code anymore
> -------------------------------------------------------------------------------------------
>
> Key: TEZ-4519
> URL: https://issues.apache.org/jira/browse/TEZ-4519
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> having classes like TezTaskRunner2 is clearly a code smell especially if the
> original class is not present in the code anymore
> it would be beneficial to change or remove the
> [comment|https://github.com/apache/tez/blob/5bba1fffdd290ae3242615c23ab3b75c24f15e88/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner2.java#L59-L61]
> accordingly:
> {code}
> // Behaviour changes as compared to TezTaskRunner
> // - Exception not thrown. Instead returned in the result.
> // - The actual exception is part of the result, instead of requiring a
> getCause().
> {code}
> look at:
> {code}
> find . -name "*2*.java"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
