[ https://issues.apache.org/jira/browse/TEZ-4378 ]


    László Bodor deleted comment on TEZ-4378:
    -----------------------------------

was (Author: tez-ci):
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 
44s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
9s{color} | {color:green} master passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
59s{color} | {color:green} master passed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 
25s{color} | {color:green} master passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
38s{color} | {color:green} master passed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
9s{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
3s{color} | {color:green} the patch passed with JDK 
Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed with JDK Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 75m 
55s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
34s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}123m 32s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-178/1/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/tez/pull/178 |
| JIRA Issue | TEZ-4378 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 263f42c467e3 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 
23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / cc8249e93 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
|  Test Results | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-178/1/testReport/ |
| Max. process+thread count | 2099 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | 
https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-178/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> tez-dist: org.checkerframework.dataflow is included with GNU GPLv2 license
> --------------------------------------------------------------------------
>
>                 Key: TEZ-4378
>                 URL: https://issues.apache.org/jira/browse/TEZ-4378
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> dataflow license is GNU GPL2: 
> https://mvnrepository.com/artifact/org.checkerframework/dataflow
> Apache vs GNU GPL: according to this 
> [source|https://www.whitesourcesoftware.com/resources/blog/top-10-apache-license-questions-answered/]
> {code}
> 4. What is the difference between the Apache License 2.0 and the GNU GPL?
> The GNU GPL is a copyleft license. So software that uses any GPL-licensed 
> component has to release its full source code and all rights to modify and 
> distribute the entire code. The Apache License 2.0 doesn’t impose any such 
> terms. You’re not forced to release your modified version. Besides, you can 
> choose to release your modified version under a different license (however, 
> you’re required to retain the Apache License for the unmodified parts of the 
> code).
> 5. Is the Apache License compatible with the GNU GPL?
> Apache License 2.0 is compatible with GPLv3, so you can freely mix the code 
> that’s released under these two licenses. The resulting software, however, 
> must be released under GPLv3.
> However, the Apache License 2.0 in incompatible with GPLv2 due to the 
> restriction that terminates the grant of patent rights if the license sues 
> over patent infringement. Previous Apache versions, being heavily based on 
> the BSD license, are compatible.
> {code}
> in the current state, dataflow is included in the tez dist package, which 
> makes anyone using tez need to comply with GPL license
> {code}
> grep -iRH "org.checkerframework.dataflow" --include="*.jar"
> ggrep: 
> tez-plugins/tez-yarn-timeline-cache-plugin/target/tez-yarn-timeline-cache-plugin-0.10.2-SNAPSHOT-jar-with-dependencies.jar:
>  binary file matches
> ggrep: 
> tez-plugins/tez-history-parser/target/tez-history-parser-0.10.2-SNAPSHOT-jar-with-dependencies.jar:
>  binary file matches
> ggrep: tez-dist/target/tez-0.10.2-SNAPSHOT/lib/checker-qual-2.5.2.jar: binary 
> file matches
> ggrep: tez-dist/target/tez-0.10.2-SNAPSHOT/lib/hadoop-shaded-guava-1.1.1.jar: 
> binary file matches
> {code}
> if I look at the checker-qual jar for example:
> {code}
> jar -tf tez-dist/target/tez-0.10.2-SNAPSHOT/lib/checker-qual-2.5.2.jar | grep 
> dataflow
> org/checkerframework/dataflow/
> org/checkerframework/dataflow/qual/
> org/checkerframework/dataflow/qual/Pure$Kind.class
> org/checkerframework/dataflow/qual/TerminatesExecution.class
> org/checkerframework/dataflow/qual/SideEffectFree.class
> org/checkerframework/dataflow/qual/Pure.class
> org/checkerframework/dataflow/qual/Deterministic.class
> {code}
> the problem is that's dangerous to remove hadoop-shaded-guava alltogether 
> from the distribution as other hadoop jars will directly depend on them
> without a hadoop solution, we should try to manually remove the problematic 
> package from hadoop-shaded-guava.jar and every other 
> *jar-with-dependencies.jar that was built by tez



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to