abstractdog commented on code in PR #308:
URL: https://github.com/apache/tez/pull/308#discussion_r1361640631
##########
tez-api/src/main/java/org/apache/tez/common/TezUtils.java:
##########
@@ -51,6 +57,14 @@
public final class TezUtils {
private static final Logger LOG = LoggerFactory.getLogger(TezUtils.class);
+ private static final int PROPERTY_THRESHOLD;
+ private static final boolean PROPERTY_MASK;
+
+ static {
+ TezConfiguration c = new TezConfiguration();
Review Comment:
I'm afraid this approach will become confusing hard to handle over time
a new TezConfiguration() in a static initializer will always pick up
whatever is present in tez-site.xml, hence we don't really have control over
that: I think if we want to be able to use the size threshold, we need to
achieve that from the actual config, which might need a bit of refactoring as
this method receives Configuration as an iterable (and we need to see the
threshold and mask property beforehand without iterating over the values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
