abstractdog commented on code in PR #317:
URL: https://github.com/apache/tez/pull/317#discussion_r1407687400
##########
tez-runtime-library/src/test/java/org/apache/tez/dag/library/vertexmanager/TestShuffleVertexManagerUtils.java:
##########
@@ -125,10 +126,10 @@ VertexManagerEvent getVertexManagerEvent(long[]
partitionSizes,
long uncompressedTotalSize, String vertexName, boolean
reportDetailedStats)
throws IOException {
ByteBuffer payload;
- long totalSize = 0;
+ final long totalSize;
// Use partition sizes to compute the total size.
if (partitionSizes != null) {
- totalSize = estimatedUncompressedSum(partitionSizes);
+ totalSize = Arrays.stream(partitionSizes).sum();
Review Comment:
does totalSize change with this patch? if it doesn't, why? if it does, can
we validate it with this unit test or in anyway that makes sense to you @okumin
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
