abstractdog commented on code in PR #312:
URL: https://github.com/apache/tez/pull/312#discussion_r1441852239
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/sort/impl/dflt/DefaultSorter.java:
##########
@@ -1399,4 +1409,18 @@ private void mergeParts() throws IOException,
InterruptedException {
}
}
}
+
+ /**
+ * Increments numSpills local counter by taking into consideration
+ * the max limit on spill files being generated by the job.
+ * If limit is reached, this function throws an IOException
+ */
+ private void incrementNumSpills() throws IOException {
Review Comment:
shouldn't this duplicated logic go to ExternalSorter instead of all children
(PipelinedSorter, DefaultSorter)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
