Aggarwal-Raghav commented on code in PR #334:
URL: https://github.com/apache/tez/pull/334#discussion_r1478118024
##########
tez-plugins/tez-protobuf-history-plugin/src/main/java/org/apache/tez/dag/history/logging/proto/ProtoMessageWritable.java:
##########
@@ -96,6 +96,9 @@ public void readFields(DataInput in) throws IOException {
cin = CodedInputStream.newInstance(din);
cin.setSizeLimit(Integer.MAX_VALUE);
}
+ if (din.in != in) {
+ cin.resetSizeCounter();
+ }
Review Comment:
Thanks for the review @zabetak.
**I missed this Java doc statement.** I was suspecting that resetting the
_totalBytesRetired_ after every message read might have unexpected impact
therefore, I resetted it after every hdfs split read. But based on the Javadoc,
I think we can reset the counter after every mesage read. Will modify the patch.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
