shameersss1 commented on code in PR #339: URL: https://github.com/apache/tez/pull/339#discussion_r1527423514
########## tez-mapreduce/src/main/java/org/apache/tez/mapreduce/committer/MROutputCommitter.java: ########## @@ -119,6 +119,7 @@ public void abortOutput(VertexStatus.State finalState) throws IOException { || jobConf.getBoolean("mapred.mapper.new-api", false)) { newApiCommitter = true; } + jobConf.set(MRJobConfig.MR_PARENT_JOB_ID, new org.apache.hadoop.mapred.JobID(String.valueOf(getContext().getApplicationId().getClusterTimestamp()), getContext().getApplicationId().getId()).toString()); Review Comment: Can we have` String.valueOf(getContext().getApplicationId().getClusterTimestamp()), getContext().getApplicationId().getId()).toString(` inside a method and re-use it in MROutput.java as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org