abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547308574
##########
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##########
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public String toString() {
return "InputDataInformationEvent [sourceIndex=" + sourceIndex + ",
targetIndex="
+ targetIndex + ", serializedUserPayloadExists=" + (userPayload !=
null)
- + ", deserializedUserPayloadExists=" + (userPayloadObject != null) +
"]";
- }
+ + ", deserializedUserPayloadExists=" + (userPayloadObject != null)
+ + serializedPath != null ? (", serializedPath=" + serializedPath) : ""
+ "]";
Review Comment:
agreed, it's time to refactor this
##########
tez-api/src/main/java/org/apache/tez/runtime/api/InputInitializerContext.java:
##########
@@ -87,7 +87,12 @@ public interface InputInitializerContext {
* @return Resource
*/
Resource getVertexTaskResource();
-
+
+ /**
+ * Get the vertex id as integer that belongs to this input.
+ */
+ int getVertexId();
Review Comment:
in hive's splitgenerator:
https://github.com/apache/hive/pull/5174/files#diff-e4b863c252f3407ad05ccb56548e9f8384e0af33ce4bf6841a0ce11b173bf00dR197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
