abstractdog commented on code in PR #339:
URL: https://github.com/apache/tez/pull/339#discussion_r1599582588
##########
tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/OutputCommitterContextImpl.java:
##########
@@ -34,14 +34,16 @@ public class OutputCommitterContextImpl implements
OutputCommitterContext {
private final String dagName;
private final String vertexName;
private final int vertexIdx;
+ private final int dagIdentifier;
private final RootInputLeafOutput<OutputDescriptor,
OutputCommitterDescriptor> output;
public OutputCommitterContextImpl(ApplicationId applicationId,
int dagAttemptNumber,
String dagName,
String vertexName,
RootInputLeafOutput<OutputDescriptor, OutputCommitterDescriptor> output,
- int vertexIdx) {
+ int vertexIdx,
+ int dagIdentifier) {
Review Comment:
if we're already changing the signature, what about another order that looks
better?
is this context used somewhere else other than tez code? I guess it's not,
we can use whatever we want, what about:
```
dagAttemptNumber
dagName
vertexName
dagId
vertexId
output
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
