abstractdog commented on PR #357:
URL: https://github.com/apache/tez/pull/357#issuecomment-2116938810
I'm actually fine with the patch, however, I'm a bit struggling to
understand the cause
this unit test looks like describing an exact scenario, however the
underlying taskattempt ids look like a mess :)
I mean, the current state without the patch is:
```
createStep("v1 : 00000[01]_0",
CriticalPathDependency.INIT_DEPENDENCY),
createStep("v2 : 00000[01]_0",
CriticalPathDependency.DATA_DEPENDENCY),
createStep("v3 : 000000_0", CriticalPathDependency.DATA_DEPENDENCY,
TaskAttemptTerminationCause.INTERNAL_PREEMPTION, null),
createStep("v2 : 00000[01]_1",
CriticalPathDependency.OUTPUT_RECREATE_DEPENDENCY),
createStep("v1 : 000000_1",
CriticalPathDependency.OUTPUT_RECREATE_DEPENDENCY,
null, Collections.singletonList("preemption of v3")),
createStep("v2 : 00000[01]_1",
CriticalPathDependency.DATA_DEPENDENCY),
createStep("v3 : 000000_1", CriticalPathDependency.DATA_DEPENDENCY)
```
this PR modifies the third occurrence of v2, so if it's just sometimes
000001_2, and is 000001_1 for the rest, then the second occurrence of v2 is
also weird: 00000[01]_1, so it's the same task attempt id (1)?...do all of the
scenarios make sense and tests what we expect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
