ayushtkn commented on code in PR #356:
URL: https://github.com/apache/tez/pull/356#discussion_r1610382381
##########
tez-dag/src/main/java/org/apache/tez/client/LocalClient.java:
##########
@@ -204,6 +206,9 @@ public ApplicationReport getApplicationReport(ApplicationId
appId) {
report.setProgress(dagAppMaster.getProgress());
report.setAMRMToken(null);
+ this.amHost = dagAppMaster.getAppNMHost();
+ this.amPort = dagAppMaster.getRpcPort();
Review Comment:
shouldn't this be ``getAppNMPort()``?
##########
tez-api/src/main/java/org/apache/tez/client/TezClient.java:
##########
@@ -1286,4 +1286,12 @@ public static ApplicationId appIdfromString(String
appIdStr) {
+ appIdStr, n);
}
}
+
+ public String getAmHost() {
+ return frameworkClient.getAmHost();
+ }
+
+ public int getAmPort() {
+ return frameworkClient.getAmPort();
+ }
Review Comment:
If anyone calls these methods before ``start()`` is invoked in that case
``frameworkClient`` would be `null` right? So we need to check for `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
