himanshu-mishra commented on code in PR #374:
URL: https://github.com/apache/tez/pull/374#discussion_r1778110555
##########
tez-dag/src/main/java/org/apache/tez/dag/app/rm/YarnTaskSchedulerService.java:
##########
@@ -2163,6 +2166,17 @@ void addDelayedContainer(Container container,
}
}
+ void removeDelayedContainer(HeldContainer container) {
+ if (container != null) {
+ synchronized(this) {
+ if (delayedContainers.remove(container)) {
+ LOG.info("Removed {} from delayed containers",
container.getContainer().getId());
+ } else {
+ LOG.warn("Unknown container {} sent for removal. Ignoring.",
container.getContainer().getId());
Review Comment:
A valid case here is when a new container is allocated - added to
delayedContainers, it is polled (removed) from queue but if there is no pending
task request `releaseContainer()` is invoked. Please suggest if the log level
should be changed in `info` or for both the newly added logs should be at
`debug`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
