liujiayi771 commented on PR #376: URL: https://github.com/apache/tez/pull/376#issuecomment-2459832810
@ayushtkn I tried to add a test case. However, I found that this modification is no longer needed in master, including the modifications in TEZ-4142 are no longer needed as well. I encountered this issue in version 0.10.2, when the protobuf version was 2.5.0. In that version, the `CodedInputStream.DEFAULT_SIZE_LIMIT` was 64MB. https://github.com/protocolbuffers/protobuf/blob/774d630bde574f5fcbb6dae6eaa0f91f7bc12967/java/src/main/java/com/google/protobuf/CodedInputStream.java#L561 However, the protobuf in master branch has now been upgraded to 3.25.5, where the `DEFAULT_SIZE_LIMIT` is now set to `Integer.MAX_VALUE` by default, so this issue no longer exists. https://github.com/protocolbuffers/protobuf/blob/9d0ec0f92b5b5fdeeda11f9dcecc1872ff378014/java/core/src/main/java/com/google/protobuf/CodedInputStream.java#L42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
