liangyu-1 commented on code in PR #394:
URL: https://github.com/apache/tez/pull/394#discussion_r1964891391


##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2390,7 +2390,9 @@ public static void main(String[] args) {
       ContainerId containerId = ConverterUtils.toContainerId(containerIdStr);
       ApplicationAttemptId applicationAttemptId =
           containerId.getApplicationAttemptId();
-
+      org.apache.hadoop.ipc.CallerContext.setCurrent(new 
org.apache.hadoop.ipc.CallerContext
+              .Builder("tez_appmaster_" + containerId.getApplicationAttemptId()
+      ).build());

Review Comment:
   > This will overwrite any existing `CallerContext`, You need to append the 
values not overwrite
   
   But in my opinion, this o`rg.apache.hadoop.ipc.CallerContext`is different 
from `org.apache.tez.client.CallerContext`, in this main function, it is the 
first time I set a new value to `org.apache.hadoop.ipc.CallerContext`, so there 
will be no existing `CallerContext`.
   
   is it correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to