[jira] [Commented] (TEZ-4633) Updating JVM flags in tez-site docs

[Raghav Aggarwal (Jira)]

    [ 
https://issues.apache.org/jira/browse/TEZ-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954110#comment-17954110
 ] 

Raghav Aggarwal commented on TEZ-4633:
--------------------------------------

[~abstractdog], any opinion on this? As tez has moved to JDK 17 can we 
remove/update code like this?

 
{code:java}
public static final String TEZ_TASK_LAUNCH_CMD_OPTS_JDK8_DEFAULT =
    "-XX:+PrintGCDetails -verbose:gc -XX:+PrintGCTimeStamps -XX:+UseNUMA 
-XX:+UseParallelGC"; {code}
 
{code:java}
static {
  if (TezCommonUtils.getJavaVersion() >= 9) {
    TEZ_AM_LAUNCH_CMD_OPTS_DEFAULT = TEZ_AM_LAUNCH_CMD_OPTS_JDK9_DEFAULT;
    TEZ_TASK_LAUNCH_CMD_OPTS_DEFAULT = TEZ_TASK_LAUNCH_CMD_OPTS_JDK9_DEFAULT;
  } else {
    TEZ_AM_LAUNCH_CMD_OPTS_DEFAULT = TEZ_AM_LAUNCH_CMD_OPTS_JDK8_DEFAULT;
    TEZ_TASK_LAUNCH_CMD_OPTS_DEFAULT = TEZ_TASK_LAUNCH_CMD_OPTS_JDK8_DEFAULT;
  }
} {code}
 

Also, to update 
[https://tez.apache.org/releases/0.8.2/tez-api-javadocs/configs/TezConfiguration.html]
 JVM flags here to adopt -Xlog etc.

 

 

 

> Updating JVM flags in tez-site docs
> -----------------------------------
>
>                 Key: TEZ-4633
>                 URL: https://issues.apache.org/jira/browse/TEZ-4633
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Raghav Aggarwal
>            Assignee: Raghav Aggarwal
>            Priority: Minor
>
> In JDK 17, JVM flags like PrintGCTimeStamps which are deprecated. Better to 
> move to -Xlog. 
> In code, we should remove  TEZ_TASK_LAUNCH_CMD_OPTS_JDK8_DEFAULT  and 
> TEZ_TASK_LAUNCH_CMD_OPTS_JDK9_DEFAULT as tez has moved to JDK17?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)