abstractdog commented on PR #419:
URL: https://github.com/apache/tez/pull/419#issuecomment-3020088625
weird things, here is what I got as verbose dependency trees, full examples
attached to jira (extracted only bcprov parts for clarity)
hadoop 3.4.0 (hadoop-common)
```
[INFO] +- org.bouncycastle:bcprov-jdk15on:jar:1.70:compile
```
tez on hadoop 3.4.0 (tez-api)
```
[INFO] +- org.apache.hadoop:hadoop-common:jar:3.4.0:compile
[INFO] | +- org.bouncycastle:bcprov-jdk15on:jar:1.70:compile
[INFO] +- org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0:test
[INFO] | +- (org.bouncycastle:bcprov-jdk15on:jar:1.70:test - omitted for
duplicate)
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.78:test
```
hadoop 3.4.1 (hadoop-common)
```
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.78.1:compile
```
tez on hadoop 3.4.1 (tez-api)
```
[INFO] +- org.apache.hadoop:hadoop-common:jar:3.4.1:compile
[INFO] | +- (org.bouncycastle:bcprov-jdk18on:jar:1.78:test - version
managed from 1.78.1; scope managed from compile; omitted for duplicate)
[INFO] +- org.apache.hadoop:hadoop-common:test-jar:tests:3.4.1:test
[INFO] | +- (org.bouncycastle:bcprov-jdk18on:jar:1.78:test - version
managed from 1.78.1; scope managed from compile; omitted for duplicate)
[INFO] +- org.bouncycastle:bcprov-jdk18on:jar:1.78:test
```
so apparently, when depending on hadoop 3.4.1 (where the bcprov compile
scope dependency looks good in hadoop project itself:
org.bouncycastle:bcprov-jdk18on:jar:1.78.1:compile), the compile time
dependency (instead of being brought as a compile-time dependency in tez), get
ommited due to a totally confusing message:
```
[INFO] | +- (org.bouncycastle:bcprov-jdk18on:jar:1.78:test - version
managed from 1.78.1; scope managed from compile; omitted for duplicate)
```
what does this mean? bcprov 1.78:test is omitted because the version is
managed from 1.78.1 (which is the version defined in hadoop), but at the same
time, I cannot see a proper 1.78.1 compile time dependency or something, this
just doesn't make sense to me
put 1-2 hours investigation, so here is what we can do:
1. merge this change and accept tez bringing this dependency with its own
${bouncycastle.version} compile time
2. understand what happened here and still let hadoop bring its
${bouncycastle.version}
maybe do 1) now, and follow-up 2) later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
