abstractdog commented on code in PR #408:
URL: https://github.com/apache/tez/pull/408#discussion_r2313566213
##########
tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java:
##########
@@ -74,14 +78,36 @@ public final class TezUtilsInternal {
private TezUtilsInternal() {}
- public static ConfigurationProto readUserSpecifiedTezConfiguration(String
baseDir) throws
- IOException {
+ public static ConfigurationProto readUserSpecifiedTezConfiguration(String
baseDir) throws IOException {
File confPBFile = new File(baseDir, TezConstants.TEZ_PB_BINARY_CONF_NAME);
try (FileInputStream fis = new FileInputStream(confPBFile)) {
return ConfigurationProto.parseFrom(fis);
}
}
+ public static Configuration readTezConfigurationXml(InputStream is) throws
IOException {
+ Configuration configuration = new Configuration();
+ if (is != null) {
+ configuration.addResource(is);
+ }
+ return configuration;
+ }
+
+ public static ConfigurationProto loadConfProtoFromText() throws IOException {
Review Comment:
right, this is supposed to be added by
[TEZ-4007](https://issues.apache.org/jira/browse/TEZ-4007) or
[TEZ-4008](https://issues.apache.org/jira/browse/TEZ-4008), removing it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
