Aggarwal-Raghav commented on code in PR #452:
URL: https://github.com/apache/tez/pull/452#discussion_r2702670648
##########
build-tools/docker/Dockerfile:
##########
@@ -96,20 +97,16 @@ RUN add-apt-repository -y ppa:longsleep/golang-backports \
#############
######
-# Install Google Protobuf 3.21.1
+# Install Google Protobuf 3.25.5
######
FROM tezbase AS protobuf
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
-RUN mkdir -p /opt/protobuf-src \
+RUN mkdir -p /opt/protobuf \
&& curl -L -s -S \
-
https://github.com/protocolbuffers/protobuf/releases/download/v21.1/protobuf-java-3.21.1.tar.gz
\
- -o /opt/protobuf.tar.gz \
- && tar xzf /opt/protobuf.tar.gz --strip-components 1 -C /opt/protobuf-src
-WORKDIR /opt/protobuf-src
-RUN ./configure --prefix=/opt/protobuf \
- && make install
-WORKDIR /root
-RUN rm -rf /opt/protobuf-src
+
https://github.com/protocolbuffers/protobuf/releases/download/v25.5/protoc-25.5-linux-x86_64.zip
\
Review Comment:
1. Protobuf removed Autotools (./configure and make). Wither we use CMake or
Bazel to build from source or directly download the protoc which is also
available on release page.
2. URL & Versioning: The version numbering scheme changed. What was
previously v3.21.x is now v25.x. The URL pattern and tarball names have changed
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
