abstractdog commented on PR #457: URL: https://github.com/apache/tez/pull/457#issuecomment-3811834128
> I think SpotBugs passed: <img alt="image" width="795" height="475" src="https://private-user-images.githubusercontent.com/25608848/541677245-5726bf8d-a50a-4f63-8e90-35dcffa47b0a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk2MTMxNjYsIm5iZiI6MTc2OTYxMjg2NiwicGF0aCI6Ii8yNTYwODg0OC81NDE2NzcyNDUtNTcyNmJmOGQtYTUwYS00ZjYzLThlOTAtMzVkY2ZmYTQ3YjBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTI4VDE1MDc0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0MjY4NTk2ODMyODAxMTcxOWM1ZjQ3MGJlZjdhNWIyMDMwMWY5OTQxYjU0MDFkNTNmNDJkNTJhM2IzZmYwZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iHR55ipr5gR1W86UFl7aXkPBYAAoJsJr6WMXP7MPKxQ";> It passes in the patch compile test, It failed in the master build, which is built without the patch. The way Yetus works is it builds first without the patch, that results in `_master_compile_tests`, then applies the patch and then again those tests. Since master is broken it will always be -1 there. > > The patch results: **root:** > > https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-457/7/artifact/out/patch-spotbugs-root.txt **tez-api:** https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-457/7/artifact/out/patch-spotbugs-tez-api.txt > > Am I missing something? LOL yes! :) the master branch doesn't contain the patch, that's the point good catch, let me cleanup the patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/25608848/541677245-5726bf8d-a50a-4f63-8e90-35dcffa47b0a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk2MTMxNjYsIm5iZiI6MTc2OTYxMjg2NiwicGF0aCI6Ii8yNTYwODg0OC81NDE2NzcyNDUtNTcyNmJmOGQtYTUwYS00ZjYzLThlOTAtMzVkY2ZmYTQ3YjBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTI4VDE1MDc0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0MjY4NTk2ODMyODAxMTcxOWM1ZjQ3MGJlZjdhNWIyMDMwMWY5OTQxYjU0MDFkNTNmNDJkNTJhM2IzZmYwZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iHR55ipr5gR1W86UFl7aXkPBYAAoJsJr6WMXP7MPKxQ"](https://private-user-images.githubusercontent.com/25608848/541677245-5726bf8d-a50a-4f63-8e90-35dcffa47b0a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk2MTMxNjYsIm5iZiI6MTc2OTYxMjg2NiwicGF0aCI6Ii8yNTYwODg0OC81NDE2NzcyNDUtNTcyNmJmOGQtYTUwYS00ZjYzLThlOTAtMzVkY2ZmYTQ3YjBhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTI4VDE1MDc0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM0MjY4NTk2ODMyODAxMTcxOWM1ZjQ3MGJlZjdhNWIyMDMwMWY5OTQxYjU0MDFkNTNmNDJkNTJhM2IzZmYwZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iHR55ipr5gR1W86UFl7aXkPBYAAoJsJr6WMXP7MPKxQ"){kind=link}