abstractdog commented on code in PR #458:
URL: https://github.com/apache/tez/pull/458#discussion_r2832984544
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -2429,7 +2430,10 @@ public static void main(String[] args) {
Objects.requireNonNull(appSubmitTimeStr,
ApplicationConstants.APP_SUBMIT_TIME_ENV + " is null");
- Configuration conf = new Configuration();
+ Configuration conf =
+
STANDALONE_ZOOKEEPER.name().equals(System.getenv(TezConstants.TEZ_FRAMEWORK_MODE))
+ ? new TezConfiguration()
+ : new Configuration();
Review Comment:
hm, that's a good question: I guess here is where we might want to get back
to the original motivation: whether a standalone TezAM docker container needs a
tez-site.xml on its classpath (and if so, could it read) or if there is another
way to configure it... isn't
[TEZ-4014](https://issues.apache.org/jira/browse/TEZ-4014) or some earlier work
already taking care of this? what do you think @Aggarwal-Raghav ?
https://github.com/apache/tez/blob/f09ba7faffff18e3197a4963764a34b69a22d656/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java#L100-L105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]