Aggarwal-Raghav commented on code in PR #465:
URL: https://github.com/apache/tez/pull/465#discussion_r2941843659
##########
pom.xml:
##########
@@ -959,11 +958,11 @@
<reuseForks>false</reuseForks>
<forkedProcessTimeoutInSeconds>900</forkedProcessTimeoutInSeconds>
<testFailureIgnore>true</testFailureIgnore>
- <argLine>-Xmx1024m -XX:+HeapDumpOnOutOfMemoryError</argLine>
- <argLine>${test.jvm.args}</argLine>
+ <argLine>@{argLine} -Xmx1024m -XX:+HeapDumpOnOutOfMemoryError
-XX:+EnableDynamicAgentLoading ${test.jvm.args}</argLine>
Review Comment:
Added `@{argLine}` because of
https://www.jacoco.org/jacoco/trunk/doc/prepare-agent-mojo.html
and `-XX:+EnableDynamicAgentLoading` because of jdk 21 + mockito (even
though I have not seen the warning in tez) but adding it is shouldn't be a
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
