Aggarwal-Raghav commented on code in PR #473:
URL: https://github.com/apache/tez/pull/473#discussion_r3037229463
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/orderedgrouped/FetcherOrderedGrouped.java:
##########
@@ -180,7 +180,7 @@ public FetcherOrderedGrouped(HttpConnectionParams
httpConnectionParams,
@VisibleForTesting
protected void fetchNext() throws InterruptedException, IOException {
try {
- if (localDiskFetchEnabled && mapHost.getHost().equals(localShuffleHost)
&& mapHost.getPort() == localShufflePort) {
Review Comment:
Shuffling is forced to read from disk i.e. shared path.
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/ShuffleUtils.java:
##########
@@ -316,6 +316,9 @@ static ByteBuffer generateDMEPayload(boolean
sendEmptyPartitionDetails,
if (!sendEmptyPartitionDetails || outputGenerated) {
String host = context.getExecutionContext().getHostName();
+ if (host == null) {
Review Comment:
was causing NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
