Aggarwal-Raghav commented on code in PR #481:
URL: https://github.com/apache/tez/pull/481#discussion_r3086188102
##########
build-tools/test-patch.sh:
##########
@@ -328,10 +328,10 @@ checkTests () {
fi
JIRA_COMMENT="$JIRA_COMMENT
- {color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
+ {color:orange}-0 tests included{color}. The patch doesn't appear to
include any new or modified tests.
Review Comment:
hmm,
Here is the scenario i'm thinking:
1. If in a PR new tests are added:
- UT passed: +1 green
- UT failed: -1 red
2. If no new UT were added:
- UT passed: -0 orange
- UT failed: -1 red
I think adding test4tests `--tests-filter` will always make `-0` even in
case of UT failure where `-1` should be given. Need to play around
`test-patch.sh` only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
