Aggarwal-Raghav commented on code in PR #483: URL: https://github.com/apache/tez/pull/483#discussion_r3107202460
########## tez-runtime-internals/src/main/proto/TezTaskUmbilicalProtocol.proto: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = "proto2"; + +option java_package = "org.apache.tez.runtime.internals.protocolPB"; +option java_outer_classname = "TezTaskUmbilicalProtocolProtos"; +option java_generic_services = true; +option java_generate_equals_and_hash = true; + +message GetTaskRequestProto { Review Comment: @steveloughran , can you please provide feedback on the updated `TezTaskUmbilicalProtocol.proto`. Because of structured mapping vs Wrapped Writable (old approach), the lineage of messages that needs to be defined has increased π ``` TezTaskAttemptID β TezTaskID β TezVertexID β TezDAGID β ApplicationId (Hadoop) β clusterTimestamp (long) + appId (int) ``` In MAPREDUCE-6706, its still Wrapped Writable as in the top comment in [TaskUmbilicalProtocol.protoβ](https://github.com/apache/hadoop/pull/8422/changes#diff-fc27c151e822829a671b28d2f6e5f8676039e6d89573458d91886920d48b51c4) Could you confirm if the level of granularity I've introduced here is what you had in mind for Tez? I want to ensure I've not over-complicated the .proto definition. ``` Writable-serialized types are carried as opaque bytes, for example jvm_context and jvm_task ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
