abstractdog commented on PR #498:
URL: https://github.com/apache/tez/pull/498#issuecomment-4472059687
> So, between Run7 and Run8 the the build time has reduced from:
>
> * Run 7 Total Time: 131m 18s
> * Run 8 Total Time: 94m 16s
> 27 minutes were saved from the CI time because of dropping the
`-Ptest-patch` during the unit test phase (which dropped the unit test duration
from 95m to 68m)
>
> **Point to Ponder:** Yetus is running build 4 times:
>
> 1. maven install: master: `mvn clean install` on master branch.
> 2. master compilation: pre-patch: `mvn clean test-compile -Ptest-patch`
on master branch, Uses `test-patch` profile to count the warnings.
> 3. maven install: patch: `mvn clean install` runs on PR/patch (Master + PR
changes)
> 4. master compilation: patch: ` mvn clean test-compile -Ptest-patch` runs
on PR/patch (Master + PR changes) to check for the warnings.
>
> Here is breakdown of each `mvn clean command`:
>
> 1. maven install: master (Build 1) : Elapsed: 6m 55s
> 2. master compilation: pre-patch (Build 2): Elapsed: 3m 55s
> 3. maven install: patch (Build 3): Elapsed: 5m 55s
> 4. master compilation: patch (Build 4): Elapsed: 3m 54s
>
> Question, Ques1 -> do we need compile plugin which is being used for
warning diff calculation? but it is taking approx 8 min i.e. 2 and 4. Ques2 ->
We can remove Step 1 and 3 as well by doing
`YETUS_ARGS+=("--plugins=all,-mvninstall")` , this is just putting the jars in
.m2
>
> **I think keeping the compile stage makes more sense as it takes less time
and check the project for sytax error. Also, `unit: patch` will anyway build
and test the whole project.**
@Aggarwal-Raghav : left some syntax comments, also thought about your
questions here:
what about shooting for all with an "install" command, so having 2 stages
(master + patch):
```
mvn clean install -Ptest-patch
```
and taking one more look, what value does the `test-patch` profile bring at
all?
https://github.com/apache/tez/blob/383ffd991a4f67babf218b28c3b9193835c4fa25/pom.xml#L1236-L1256
is it just for having custom compiler arguments, other than what we have in
case of a simple `mvn clean install` command?
also, I guess the `test-patch` naming was brought by TEZ-1313 in the early
years of the project (the name must have matched the yetus terminology): I'm
just thinking aloud, considering that `test-patch.sh` is removed from the
codebase now, we can also rename/refactor profiles if they make more sense (not
necessary, just an idea)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
