deniskuzZ commented on PR #542:
URL: https://github.com/apache/tez/pull/542#issuecomment-5871359829
The bufcompat -1 is structural for this PR and cannot go green here. Yetus's
bufcompat_preapply runs buf build on the unpatched base branch before the patch
is applied; master has no buf.yaml, so every cross-file import fails (imported
file does not exist for import "DAGApiRecords.proto", a same-directory import)
and the plugin votes -1 before this change is even considered.
it needs to be merged over the vote once, after which the branch side builds
and bufcompat runs for real on every later PR.
The check that does run on the patched tree is buflint, and it went from 28
errors to 0 on this PR — that's the config working.
Verified locally with buf 1.73 (CI runs 1.68.2): buf build and buf lint
clean on master;
The unit failures are unrelated to a YAML file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
