[ 
https://issues.apache.org/jira/browse/TEZ-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909136#comment-13909136
 ] 

Tassapol Athiapinya commented on TEZ-877:
-----------------------------------------

It was the latter, task attempts. If left unchanged, I can add incorrect 
expected value and test will still pass. A bug could escape. To be clear, this 
jira is about testing. Output verification here is TestProcessor which is used 
only in Tez testing. We want to fix this jira to make fault tolerance testing 
more solid.

> Output verification should be strict enough to disregard relaunched attempt.
> ----------------------------------------------------------------------------
>
>                 Key: TEZ-877
>                 URL: https://issues.apache.org/jira/browse/TEZ-877
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.3.0
>            Reporter: Tassapol Athiapinya
>             Fix For: 0.3.0
>
>
> In current output verification framework, new attempt can pollute test result.
> For example, if test expects output of attempt 0 of a vertex to be N. If 
> actual output is N-1, test will still pass because once output verification 
> of N-1 fails, new attempt will be launched. We calculate sum of the vertex by 
> summing input values and its attempt number+1. With new attempt, sum of the 
> vertex is bumped by one to N and test will pass.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to