[
https://issues.apache.org/jira/browse/TEZ-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934212#comment-13934212
]
Siddharth Seth edited comment on TEZ-707 at 3/14/14 1:04 AM:
-------------------------------------------------------------
[~airbots]. I looked at the patch for a bit. This will still not work with
multiple threads, so I don't see any purpose of adding the configuration
specifying this.
There's now a constructor which is setting a static field - that's rather
strange.
All the statics will need to be removed if there's any possibility of this
working with multiple tasks.
currentTask is a dead variable after returning from the poll - will always be
null. Most IDEs should warn about this.
Didn't spend too much more time looking at the patch.
For now, please leave YarnTezDagChild as is - and try pulling it's
functionality into a separate class which can be used by different modules, and
with multiple instances of that from within the same JVM. Eventually (as a
separate jira), YarnTezDagChild can start using this. Getting rid of most of
the statics would be a good first step, then deciding on what to expose so that
this becomes usable by the LocalContainerLauncher.
Also, formatting used in Tez is the same as Hadoop -
http://wiki.apache.org/hadoop/HowToContribute - except with a 100 character
limit. (HowToContribute for Tez is still to be setup)
was (Author: sseth):
[~airbots]. I looked at the patch for a bit. This will still not work with
multiple threads, so I don't see any purpose of adding the configuration
specifying this.
There's now a constructor which is setting a static field - that's rather
strange.
All the statics will need to be removed if there's any possibility of this
working with multiple tasks.
currentTask is a dead variable after returning from the poll - will always be
null. Most IDEs should warn about this.
Didn't spend too much more time looking at the patch.
For now, please leave YarnTezDagChild as is - and try pulling it's
functionality into a separate class which can be used by different modules, and
with multiple instances of that from within the same JVM. Eventually (as a
separate jira), YarnTezDagChild can start using this.
Also, formatting used in Tez is the same as Hadoop -
http://wiki.apache.org/hadoop/HowToContribute - except with a 100 character
limit. (HowToContribute for Tez is still to be setup)
> Get a single vertex DAG work in Uber-mode
> ------------------------------------------
>
> Key: TEZ-707
> URL: https://issues.apache.org/jira/browse/TEZ-707
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.3.0
> Reporter: Chen He
> Assignee: Chen He
> Attachments: Tez-707.patch.v2, tez-707.patch
>
>
> Create LocalContainerLauncher and make it work for a single stage DAG. The
> TaskSchedulerEventHandler still asks RM for new container but
> LocalContainerLauncher will run TezTask in form of thread instead of using
> this container from yarn.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
