[
https://issues.apache.org/jira/browse/TEZ-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971789#comment-13971789
]
Siddharth Seth commented on TEZ-919:
------------------------------------
Thanks for the review.
bq. code and comment dont match up.
Fixed
bq. remove TODOs in new exception ?
Done
bq. does this need to be an atomic boolean?
Is volatil, which should be sufficient in this case.
bq. why does shutdown() have a check for gating multiple calls? But calling
shutdownInternal() multiple times is allowed?
shutdownInternal can be called from within the class itself, when it detects
that shutdown has been invoked. The method is safe to invoke multiple times.
It's possible for a shutdown to be called, but not register to shutdown the
actual fetcher thread depending on where it is in it's processing. That's the
case where shutdownInternal gets invoked - in case a cconnection / input is
being setup when shutdown is called (since those are not interruptable
operations).
Will upload and commit an updated patch in a bit.
> Fix shutdown handling for Shuffle (regular and broadcast)
> ---------------------------------------------------------
>
> Key: TEZ-919
> URL: https://issues.apache.org/jira/browse/TEZ-919
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-919.1.txt
>
>
> Split from TEZ-711. Shutting down ShuffledInput and ShuffledUnsortedInput
> needs some work.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
