[
https://issues.apache.org/jira/browse/TEZ-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974657#comment-13974657
]
Bikas Saha commented on TEZ-695:
--------------------------------
I am clear as to why this introduces a race? If there is a race then its
pre-existing. If the earlier impls did not have a race while accessing
numInputs and getContext() then they should not have that now. This patch has
not logically changed the ordering. The Tez framework first sets
RealInput.numInputs then calls RealInput.initialize(context). Now that changes
to Tez framework first sets AbsInput.numInputs, then call
AbsInput.initialize(context)->RealInput.initialize().
> Create Abstract class for Input/Processor/Output
> ------------------------------------------------
>
> Key: TEZ-695
> URL: https://issues.apache.org/jira/browse/TEZ-695
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Mohammad Kamrul Islam
> Fix For: 0.5.0
>
> Attachments: TEZ-695.1.patch, TEZ-695.2.patch, TEZ-695.3.patch,
> TEZ-695.4.patch, TEZ-695.5.patch, TEZ-695.6.patch
>
>
> Currently, the context is passed to IPO objects in the initialize method and
> its their burden to save a copy for future use. Having an abstract class for
> them would allow common things like this to be done in the abstract class and
> reduce the burden on the IPO developer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
