[
https://issues.apache.org/jira/browse/TEZ-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997820#comment-13997820
]
Siddharth Seth commented on TEZ-1114:
-------------------------------------
Mostly minor comments.
- Fetchers have some unused imports and variables related to ssl.
- For the ScatterGather Shuffle, can the SSL shutdown be moved into
ShuffleScheduler instead of being invoked by each Fetcher thread. (Broadcast
Shuffle already does this after the patch)
- HttpConnectionParamsBuilder.setSSL - can this end up initializing the
sslHandler multiple times when called concurrently ? May be better of just
synchronizing the entire initialization block. Also, is the else condition
required - cleanupSSLFactory().
- ShuffleManager.constructFetcherForHost - does need HttpConnectionParams do be
an additional parameter; it's already an instance variable.
- Ideally, connectionParameters should be setup only once for the
ShuffleScheduler also - but that's not related to this patch.
Otherwise looks good to me.
> DAGs fail with ClassCast exception when encrypted shuffle is enabled.
> ----------------------------------------------------------------------
>
> Key: TEZ-1114
> URL: https://issues.apache.org/jira/browse/TEZ-1114
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Rajesh Balamohan
> Attachments: TEZ-1114-v1.patch, TEZ-1114-v2.patch
>
>
> The failure should be detected early by the fetcher and a better error
> message generated denoting that ssl is not supported for now.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
