[
https://issues.apache.org/jira/browse/TEZ-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002684#comment-14002684
]
Bikas Saha commented on TEZ-1075:
---------------------------------
[~hitesh]Had some reservations on this.
On the patch itself. The termination cause and diagnostics are probably not
required.
{code}- // If we have no vertices, fail the dag
+ // If we have no vertices, pass the dag
numVertices = getJobPlan().getVertexCount();
if (numVertices == 0) {
addDiagnostic("No vertices for dag");
trySetTerminationCause(DAGTerminationCause.ZERO_VERTICES);{code}
> 0 vertex dags should succeed
> ----------------------------
>
> Key: TEZ-1075
> URL: https://issues.apache.org/jira/browse/TEZ-1075
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Chen He
> Labels: newbie++
> Attachments: TEZ-1075.patch
>
>
> Currently 0 vertex dags fail because of the following code in DAGImpl
> {code} if (numVertices == 0) {
> addDiagnostic("No vertices for dag");
> trySetTerminationCause(DAGTerminationCause.ZERO_VERTICES);
> if (event != null) {
> return DAGState.FAILED;
> }
> return finished(DAGState.FAILED);
> }
> {code}
> IMO a 0 vertex DAG is a legitimate construct and should just pass. Similar to
> a 0 task vertex. Its essentially a no-op operation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
