[
https://issues.apache.org/jira/browse/TEZ-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011562#comment-14011562
]
Bikas Saha commented on TEZ-800:
--------------------------------
Comments will be added and typos fixed in the next patch.
bq. no handling for vertices that have multiple inbound edges of different
types or even all inbounds being of type 1:1
Multiple inbounds of 1-1 type are considered (and there is a test for it too).
Multiple inbound types are not considered since only the 1-1 edge has the
producer-consumer parallelism tight coupling.
bq. test with re-ordering of the vertices
testVerifyOneToOneIncorrectParallelism2() actually catches one ordering case.
But I can add a duplicate test with the order changed.
bq. Is there a reason why this was not caught by the AM
The checks and errors are better off at compile time than have it fail much
later at runtime IMO.
Thanks for the review!
> One-one edge with parallelism -1 fails if source vertex parallelism is not -1
> as well
> -------------------------------------------------------------------------------------
>
> Key: TEZ-800
> URL: https://issues.apache.org/jira/browse/TEZ-800
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Rohini Palaniswamy
> Assignee: Bikas Saha
> Attachments: TEZ-800.1.patch
>
>
> // no input initializers. At this moment, only other case is 1-1 edge
> // with uninitialized sources
> boolean hasOneToOneUninitedSource = false;
> for (Map.Entry<Vertex, Edge> entry :
> vertex.sourceVertices.entrySet()) {
> if (entry.getValue().getEdgeProperty().getDataMovementType() ==
> DataMovementType.ONE_TO_ONE) {
> if (entry.getKey().getTotalTasks() == -1) {
> hasOneToOneUninitedSource = true;
> break;
> }
> }
> }
> This checks for the source vertex which has the 1-1 edge to also have -1
> parallelism.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
